Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add EnforceSizeLimit to enforce the specified search request size limit (fixes #431) #482

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Conversation

cpuschma
Copy link
Member

This PR adds a new optional attribute that, when enabled, enforces a hard limit on the maximum number of parsed entries from a search request to the requested SizeLimit. This behaviour is disabled by default.

See #431 for why this might be necessary.

@cpuschma cpuschma changed the title Add EnforceSizeLimit to enforce the specified search request size limit (fixes #431) feat: Add EnforceSizeLimit to enforce the specified search request size limit (fixes #431) Jan 27, 2024
Copy link
Member

@johnweldon johnweldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@cpuschma cpuschma merged commit 2d1e4db into go-ldap:master Jan 28, 2024
20 checks passed
@cpuschma cpuschma deleted the feat/hard_sizelimit branch January 28, 2024 12:37
gustavoluvizotto pushed a commit to gustavoluvizotto/ldap-fork that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants