Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go versions to 1.18+ #203

Merged
merged 2 commits into from
Aug 5, 2023
Merged

Bump go versions to 1.18+ #203

merged 2 commits into from
Aug 5, 2023

Conversation

thockin
Copy link
Contributor

@thockin thockin commented Aug 4, 2023 •
edited
Loading

Fixes #202

@thockin thockin mentioned this pull request Aug 4, 2023
Closed
4 tasks
pohly
pohly reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do a search/replace for s/interface{}/any/, either in this PR or a separate one?

Or do we transition organically as code using interface{} gets touched?

Personally I prefer a global search/replace to keep the code base consistent.

@thockin
Copy link
Contributor Author

thockin commented Aug 4, 2023

Good idea, new commit added

@pohly pohly merged commit 4c4e60e into go-logr:master Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly approved these changes

Assignees

@pohly pohly

@thockin thockin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump min Go version to at least 18?
2 participants
@thockin @pohly