Fix SetCursorTimeout. See https://jira.mongodb.org/browse/SERVER-24899 #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@niemeyer it looks like one of the Travis builds failed because a port was already in use. |
|
Thanks! Just restarted the failing test. Speaking of tests, can we have a test that breaks so we can be sure these changes are doing what we want them to do in the future? |
|
You had a test case for cursors that are supposed to time out, but no test case for cursors that aren't supposed to time out. |
|
Any reason this hasn't been merged yet? The behavior for no timeout can't get any more broken than it currently is, no matter if there's a test for no timeout. |
This was referenced May 9, 2017
|
Is there anything missing to this PR to get it merged? |
fmpwizard
added a commit
to ascendantcompliance/mgo
that referenced
this pull request
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tailable,AwaitData, andNoCursorTimeoutwere not set, and for some reason MongoDB has two copies of each flag. And it was looking at the other set.