Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query in pathPattern will miss after build http request #134

Open
nan-mu-cs opened this issue Apr 5, 2019 · 2 comments
Open

Query in pathPattern will miss after build http request #134

nan-mu-cs opened this issue Apr 5, 2019 · 2 comments
Labels
needs more info

Comments

@nan-mu-cs
Copy link

nan-mu-cs commented Apr 5, 2019 •
edited
Loading

Support I have a pathPattern /api/{id}/hello?action=create
logic in here: https://github.com/go-openapi/runtime/blob/master/client/request.go#L133-L134

req.URL.RawQuery = r.query.Encode()
req.Header = r.header

won't carry action=create to new http request query part
@fredbi
Copy link
Member

fredbi commented Apr 5, 2019 •
edited
Loading

Do you have a sample spec where this fails?
I have been running fine with similar patterns.

@nan-mu-cs
Copy link
Author

sure, will add sample later today

kzys pushed a commit to kzys/runtime that referenced this issue Dec 17, 2022
@sipsma
Merge pull request go-openapi#134 from sipsma/container-ci-pr
6927857 
Run tests in containers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs more info
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nan-mu-cs @fredbi