Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly route requests that contain colons within a path segment #162

Closed
seanprince opened this issue Oct 31, 2019 · 0 comments · Fixed by #164
Closed

Correctly route requests that contain colons within a path segment #162

seanprince opened this issue Oct 31, 2019 · 0 comments · Fixed by #164

Comments

@seanprince
Copy link
Contributor

If a Swagger definition defines 2 paths of the form:

POST /myresource:validate
POST /myresource:batchRetrieve

The requests to these two endpoints are routed to the incorrect handler.

This is because makeRecords in middleware/denco/router.go interprets the presence of any colon in the path as a path parameter, rather than a static path in this case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Colon must be at beginning of path segment to denote a path parameter seanprince/runtime
1 participant
@seanprince