Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colon must be at beginning of path segment to denote a path parameter #164

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

seanprince
Copy link
Contributor

@seanprince seanprince commented Nov 8, 2019

Signed-off-by: Sean Prince 7532924+seanprince@users.noreply.github.com

Tightened route parsing to treat colons appearing as the first character of a path segment as path parameters. Colons appearing elsewhere in the path segment are treated as a static path segment.

This PR fixes #162

Signed-off-by: Sean Prince <7532924+seanprince@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #164 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   80.13%   80.14%   +<.01%     
==========================================
  Files          40       40              
  Lines        2351     2352       +1     
==========================================
+ Hits         1884     1885       +1     
  Misses        361      361              
  Partials      106      106
Impacted Files Coverage Δ
middleware/denco/router.go 93.57% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 553c9d1...0aa3c49. Read the comment docs.

@casualjim casualjim merged commit fe6d8cc into go-openapi:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correctly route requests that contain colons within a path segment
2 participants