-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ByteStreamConsumer can't write to interface{} #167
Labels
Comments
Similar issue for |
kzys
pushed a commit
to kzys/runtime
that referenced
this issue
Dec 17, 2022
Allow parallel VM creation
fredbi
added a commit
to fredbi/runtime
that referenced
this issue
Dec 7, 2023
ByteStreamConsumer may write into an interface which underlying type is []byte or string. * fixes go-openapi#167 This PR affects only the ByteStreamConsumer. Obviously, there is a lot of commonality with the TextConsumer, which could be augmented the same way in a follow-up. Also the newly proposed type switch could benefit the Producer. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
added a commit
to fredbi/runtime
that referenced
this issue
Dec 8, 2023
ByteStreamConsumer may write into an interface which underlying type is []byte or string. * fixes go-openapi#167 This PR affects only the ByteStreamConsumer. Obviously, there is a lot of commonality with the TextConsumer, which could be augmented the same way in a follow-up. Also the newly proposed type switch could benefit the Producer. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
added a commit
to fredbi/runtime
that referenced
this issue
Dec 10, 2023
ByteStreamConsumer may write into an interface which underlying type is []byte or string. * fixes go-openapi#167 This PR affects only the ByteStreamConsumer. Obviously, there is a lot of commonality with the TextConsumer, which could be augmented the same way in a follow-up. Also the newly proposed type switch could benefit the Producer. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
added a commit
to fredbi/runtime
that referenced
this issue
Dec 11, 2023
ByteStreamConsumer may write into an interface which underlying type is []byte or string. * fixes go-openapi#167 This PR affects only the ByteStreamConsumer. Obviously, there is a lot of commonality with the TextConsumer, which could be augmented the same way in a follow-up. Also the newly proposed type switch could benefit the Producer. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
added a commit
to fredbi/runtime
that referenced
this issue
Dec 11, 2023
* fix(ByteStreamConsumer): may now write into an interface which underlying type is []byte or string. * feat(ByteStreamConsumer): added support to io.ReaderFrom, preferred over io.Writer if available * feat(ByteStreamProducer): added support to io.WriterTo, preferred over io.Reader if available * refact(ByteStreamProducer): removed redundant case "string" and preferred the more general reflected case (supports aliased strings) * test: refactored ByteStream tests * test: added benchmark for bytestream.Consume * fixes go-openapi#167 Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
added a commit
that referenced
this issue
Dec 12, 2023
* fix(ByteStreamConsumer): may now write into an interface which underlying type is []byte or string. * feat(ByteStreamConsumer): added support to io.ReaderFrom, preferred over io.Writer if available * feat(ByteStreamProducer): added support to io.WriterTo, preferred over io.Reader if available * refact(ByteStreamProducer): removed redundant case "string" and preferred the more general reflected case (supports aliased strings) * test: refactored ByteStream tests * test: added benchmark for bytestream.Consume * fixes #167 Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ByteStreamConsumer won't write to a destination of type
interface{}
even if it has a concrete type of[]byte
produces
The text was updated successfully, but these errors were encountered: