Fix failed windows tests that depends on cwd #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Youyuan Wu youyuanwu@outlook.com
Failed tests on master:
The cause of failure is that the tests were running in D:/ drive in stead of C:/ drive in github action.
Not sure the filepath.abs() changed behaviour or not. i.e. if it always returns C:/.
The fix is to change tests to have expected value matching the current drive.