Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable linters and skip lines to lint #100

Merged
merged 1 commit into from
Feb 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ linters:
- godot
- exhaustivestruct
- paralleltest
- varnamelen
- ireturn
#- thelper

issues:
Expand Down
1 change: 1 addition & 0 deletions date_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ func TestDate_Equal(t *testing.T) {
d2 := Date(time.Date(2020, 10, 11, 12, 13, 14, 15, time.UTC))
d3 := Date(time.Date(2020, 11, 12, 13, 14, 15, 16, time.UTC))

//nolint:gocritic
assert.True(t, d1.Equal(d1), "Same Date should Equal itself")
assert.True(t, d1.Equal(d2), "Date instances should be equal")
assert.False(t, d1.Equal(d3), "Date instances should not be equal")
Expand Down
1 change: 1 addition & 0 deletions format.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ type defaultFormats struct {

// NewFormats creates a new formats registry seeded with the values from the default
func NewFormats() Registry {
//nolint:forcetypeassert
return NewSeededFormats(Default.(*defaultFormats).data, nil)
}

Expand Down
1 change: 1 addition & 0 deletions time_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,7 @@ func TestDateTime_Equal(t *testing.T) {
dt1 := DateTime(time.Now())
dt2 := DateTime(time.Time(dt1).Add(time.Second))

//nolint:gocritic
assert.True(t, dt1.Equal(dt1), "DateTime instances should be equal")
assert.False(t, dt1.Equal(dt2), "DateTime instances should not be equal")
}
1 change: 1 addition & 0 deletions ulid_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ func TestFormatULID_NewULID_and_Equal(t *testing.T) {
ulid2, err := NewULID()
assert.NoError(t, err)

//nolint:gocritic
assert.True(t, ulid1.Equal(ulid1), "ULID instances should be equal")
assert.False(t, ulid1.Equal(ulid2), "ULID instances should not be equal")

Expand Down