Initial #3
Open
Initial #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnicoYal
force-pushed
the
release/http-base-application
branch
from
0e83c00
to
83f53ee
Compare
UnicoYal
force-pushed
the
release/http-base-application
branch
from
83f53ee
to
a5a5cb3
Compare
Starlexxx
requested changes
Sep 22, 2024
Starlexxx
reviewed
Sep 23, 2024
UnicoYal
force-pushed
the
release/http-base-application
branch
from
d5cc980
to
f5d08ad
Compare
Starlexxx
reviewed
Sep 23, 2024
UnicoYal
force-pushed
the
release/http-base-application
branch
from
25f5376
to
ba71236
Compare
UnicoYal
commented
Sep 24, 2024
|
|
||
| func Login(ctx context.Context, api *api.Implementation, next http.Handler) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| w.Header().Set("Content-Type", "application/json") |
UnicoYal
force-pushed
the
release/http-base-application
branch
from
b5d74b8
to
19e8f70
Compare
UnicoYal
force-pushed
the
release/http-base-application
branch
from
cb2ac39
to
d05978c
Compare
Starlexxx
reviewed
Sep 27, 2024
| func (a *App) GracefulShutdown() error { | ||
| log.Println("Starting graceful shutdown") | ||
|
|
||
| if err := a.Database.Close(); err != nil { |
There was a problem hiding this comment.
у тебя во время того, как выполняется шатдаун, апа все еще может принимать запросы, которые могут ходить в базу и тд. Нужно чтобы у приложения был стейт типа готово принимать, не готово или что-то подбное
There was a problem hiding this comment.
странно, пускай будет просто internal/app/handlers/auth.go
| "github.com/go-park-mail-ru/2024_2_GOATS/internal/app/models/cookie" | ||
| ) | ||
|
|
||
| type AuthHandler struct { |
There was a problem hiding this comment.
Название структуры не должно начинаться с названия пакета
| loginResp, errResp := a.ApiLayer.Login(a.Context, loginData) | ||
| if errResp != nil { | ||
| w.WriteHeader(errResp.StatusCode) | ||
| json.NewEncoder(w).Encode(errResp) |
There was a problem hiding this comment.
encode ошибку возвращает, надо обрабатывать
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| w.Header().Set("Content-Type", "application/json") | ||
|
|
||
| cookie, err := r.Cookie("session_id") |
There was a problem hiding this comment.
коллизия с названием пакета
| timeout: 4s | ||
| idleTimeout: 60s | ||
|
|
||
| # postgres: local |
internal/db/schema/db.sql
Outdated
|
|
||
| INSERT INTO public.movies (title, country_id, description, release_date, movie_type) | ||
| VALUES | ||
| ('Оно', 2, 'Когда в городке Дерри, штат Мэн, начинают пропадать дети, несколько ребят сталкиваются со своими величайшими страхами и вынуждены помериться силами со злобным клоуном Пеннивайзом, чьи проявления жестокости и список жертв уходят в глубь веков.', '2017-09-07', 'film'), |
There was a problem hiding this comment.
не относится к схеме, это сиды
| title varchar NOT NULL UNIQUE, | ||
| created_at timestamp WITH TIME ZONE DEFAULT CURRENT_TIMESTAMP, | ||
| updated_at timestamp WITH TIME ZONE DEFAULT CURRENT_TIMESTAMP, | ||
| CONSTRAINT valid_title CHECK ( LENGTH(title) >= 3 ) |
There was a problem hiding this comment.
лично я против валидаций на уровне бд, у тебя есть приложение для этого
| username varchar UNIQUE, | ||
| email varchar NOT NULL UNIQUE, | ||
| password_hash varchar NOT NULL, | ||
| sex varchar CHECK(sex IN ('male', 'female', 'other', 'secret')), |
| album_url varchar DEFAULT '', | ||
| release_date date NOT NULL, | ||
| rating decimal(10,2) DEFAULT '0.0', | ||
| movie_type varchar CHECK(movie_type IN ('film', 'serial')), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
База для монолита на хттп