Add basic support for 5.7.0+ yubikeys that default to AES192 management keys #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal changes to add support for 5.7.0+ yubikeys that default to AES192 management keys
ericchiang
reviewed
Jun 29, 2024
|
|
||
| // If yubikey is 5.7.0 or newer, management key default is AES192 | ||
| if int(v.major) >= 5 && int(v.minor) >= 7 { | ||
| DefaultManagementKeyType = algAES192 |
There was a problem hiding this comment.
can this be on the client rather than global to the package?
There was a problem hiding this comment.
I tested with v4.3.7, v5.4.3, and v5.7.1 yubikeys. It has been possible for users to change the type of management key since 5.4, but the default has remained 3DES. I decided in lieu of this minimal fix, I would take things a step further and just implement dynamic support for all the supported management key types. Closing this PR in favor of : #149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to add basic support for 5.7.0+ yubikeys that default to AES192 management keys rather than the previous default of 3DES. Assumes management key type is the default type for the key version - does not support non-default management key types, but it didn't before anyway.