Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golangci-lint warnings #214

Merged
merged 4 commits into from
Aug 31, 2024

Conversation

cyb3r4nt
Copy link
Contributor

Recent version of golangci-lint started to produce some warnings.
I created some fixes for those.

cyb3r4nt added 4 commits June 3, 2024 15:01
Now it is possible to have a configuration,
where only one single dev provider is enabled.

Providers were not registered into Service.authMiddleware.Provicers slice
in the Service.AddDevProvider() and Service.AddAppleProvider() methods before.
@cyb3r4nt cyb3r4nt requested a review from umputun as a code owner August 30, 2024 12:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10632296700

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.371%

Totals Coverage Status
Change from base Build 10155852578: 0.0%
Covered Lines: 2582
Relevant Lines: 3097

💛 - Coveralls

@cyb3r4nt
Copy link
Contributor Author

Fixes for the failed build job are here: #215

@umputun umputun merged commit fa44af5 into go-pkgz:master Aug 31, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants