Benchmarks middleware #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this thing is collecting and reporting performance metrics, i.e. number of request, req/sec, max/min resp time and average resp time for a given (last) duration
Pull Request Test Coverage Report for Build 2328494763
💛 - Coveralls |
|
@paskal could you pls review it? this is conceptually somewhat similar to the thing you did in the rlb-stats project |
paskal
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to add a simple middleware collecting and reporting performance metrics of requests/responses. It keeps track of the response speed (average, min, and max) as well as request counts in 1s benchData buckets limiting the number of buckets
to maxTimeRange (900, for a max of 15 minutes).
Users can request the benchmark for any aggregated time duration, however, anything above maxTimeRange won't make any difference. This is intended to be used for retrieving the benchmark data for the last minute, 5 minutes, and up to 15m. Somewhat similar to how Linux reports load averages.