slice, array: interface must be a pointer to a struct

[themihai]

It seems slice and array types are supported only on struct properties.

[deankarn]

Hey @themihai

currently that is correct, as the description states Package form Decodes url.Values into struct values

however, it actually might not be that hard to also decode directly into variables such as arrays or maps.

I will look into the possibility of adding this tonight after I get off work; thanks for the idea.

[themihai]

You're right! I was quick to jump on the "Supported Types" section instead to read documentation more thoroughly. Support for direct values would be nice as it would put query encoding on par with the other formats(i.e. json).

[themihai]

I've tried a quick decoding implementation of direct struct slices(just hooked-up the slice decoding method into the main Decode function) but unfortunately some tests(see the commented out lines) are failing. These seem to be related to maps and arrays of the struct properties so I guess I'm missing some important steps in the decoding process.

[deankarn]

Hey @themihai

It is a good attempt, I think you just may be overcomplicating it; all of the logic already exists to parse slices and maps, what I was thinking was change this line to call setFieldByType

and the rest should handle itself, at least that's the theory ;)

UPDATE: oh and put the traverseStruct in an else{}

[deankarn]

Hey @themihai just an FYI, I've completed the Decoder portion of these changes and if all goes well will finish up making the same changes to Encoder in the morning and will then cut a new release

[themihai]

Indeed, it was easier than I thought! Looking forward for the updates! With this change the encoder supports pretty much any valid data type including basic types.

[deankarn]

Hey @themihai this change has been made is in Release 2.0.0

if there are any issues please don't hesitate to reopen.

[deankarn]

Hey @themihai just checking to make sure this is working out for you?