Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to CLDR 32.0.1 #20

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Conversation

vvohra
Copy link

@vvohra vvohra commented Mar 8, 2018

  • I downloaded the latest CLDR 32.0.1 and extracted to ./cmd/data
  • I updated the enHeritance to be a list of maps for all current parents defined in supplementalData.xml

Maybe we can extract the parents from the XML instead of hard coding it?

I'm seeing new locales, I think that's expected?

@deankarn
Copy link
Contributor

Hey @vvohra

thanks for the PR, would you be able to fix the tests for ue?

--- FAIL: TestPercent (0.00s)
	ue_test.go:39: Expected '% -1.023,45' Got '% −1.023,45'
FAIL
FAIL	github.com/go-playground/locales/eu	0.028s

Then I'll merge :)

P.S. Thanks I've had very little time to work on this lately, I definitely want to improve it, but rather than focusing on the XML I would like to convert this to use the CLDR JSON as most of the inheritance is already parsed and I can focus more on the library itself.

@vvohra
Copy link
Author

vvohra commented Mar 21, 2018

Hey! Similar to you, I also have limited availability. Because I felt the work to using JSON files is not trivial, I made the small changes for inheritance and loaded the latest data for now.

Let me know how you feel.

@deankarn
Copy link
Contributor

Change look great @vvohra Thanks, will try to merge it in the next couple of days.

@deankarn deankarn merged commit 4e89b35 into go-playground:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants