Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow byte slice and json raw message in IsJson #1110

Merged
merged 2 commits into from
Jun 4, 2023
Merged

allow byte slice and json raw message in IsJson #1110

merged 2 commits into from
Jun 4, 2023

Conversation

vesquen
Copy link
Contributor

@vesquen vesquen commented May 25, 2023

Fixes Or Enhances

  • json.RawMessage and []byte can be validated as JSON

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@vesquen vesquen requested a review from a team as a code owner May 25, 2023 07:09
@coveralls
Copy link

coveralls commented May 25, 2023 •
edited
Loading

Coverage Status

Coverage: 73.97% (+0.01%) from 73.958% when pulling 5081738 on Vesquen:feat-json-raw-message-and-byte-slice-support into ce28d7c on go-playground:master.

@vesquen vesquen mentioned this pull request May 25, 2023
Closed
2 tasks
deankarn
deankarn approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Awesome!

@deankarn deankarn merged commit fcd0d86 into go-playground:master Jun 4, 2023
@vesquen vesquen deleted the feat-json-raw-message-and-byte-slice-support branch June 4, 2023 15:23
@sahidvelji
Copy link

Closes #1083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn deankarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vesquen @coveralls @sahidvelji @deankarn