Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some base32 parsing issues by using go standard library instead of regex #1286

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jamesatkin-myndup
Copy link
Contributor

Fixes Or Enhances

Some strings were failing to be parsed by the previous RegEx based validation. This now uses the Go base32 module (part of the standard library) to more reliably decode the field.

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@jamesatkin-myndup jamesatkin-myndup requested a review from a team as a code owner June 26, 2024 15:03
@coveralls
Copy link

Coverage Status

coverage: 74.3% (+0.009%) from 74.291%
when pulling 14dc595 on jamesatkin-myndup:master
into a947377 on go-playground:master.

@coveralls
Copy link

Coverage Status

coverage: 74.297% (+0.006%) from 74.291%
when pulling c17835f on jamesatkin-myndup:master
into a947377 on go-playground:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants