Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing slash removed #119

Closed
lucadepaoli opened this issue Jan 26, 2018 · 2 comments
Closed

Trailing slash removed #119

lucadepaoli opened this issue Jan 26, 2018 · 2 comments
Assignees
@jeevatkm
Labels
bug
Milestone
v1.2 Milestone

Comments

@lucadepaoli
Copy link

After commit ad03978, if a request is made with a trailing slash, it is removed in function composeRequestURL (from util.go).
This is not expected, since there are many APIs that require trailing slashes to the endpoints.
@jeevatkm jeevatkm self-assigned this Jan 26, 2018
@jeevatkm jeevatkm added the bug label Jan 26, 2018
@jeevatkm
Copy link
Member

@lucadepaoli I understand, let me address that quickly and make an release. Thank you for notifying.

@jeevatkm jeevatkm added this to the v1.2 Milestone milestone Jan 26, 2018
jeevatkm added a commit that referenced this issue Jan 26, 2018
@jeevatkm
#119 trailing slash fix and release version update
c647405
@jeevatkm jeevatkm mentioned this issue Jan 26, 2018
Merged
jeevatkm added a commit that referenced this issue Jan 26, 2018
@jeevatkm
#119 trailing slash fix and release version update (#120)
00cb083
@jeevatkm
Copy link
Member

@lucadepaoli I have fixed it, making release v1.2. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevatkm jeevatkm

Labels
bug
Milestone
v1.2 Milestone
Development

No branches or pull requests
2 participants
@jeevatkm @lucadepaoli