Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug mode dumps secret Auth headers #180

Closed
CallMeFoxie opened this issue Aug 28, 2018 · 2 comments · Fixed by #186
Closed

Debug mode dumps secret Auth headers #180

CallMeFoxie opened this issue Aug 28, 2018 · 2 comments · Fixed by #186
Labels
enhancement
Milestone
v1.10.0 Milestone

Comments

@CallMeFoxie
Copy link

Hi
it seems that enabling a debug mode dumps password right into the console making it hard to share the log with developers etc. IMHO there should be some filter to filter at least the basic auth/bearer tokens/... out.

---------------------- REQUEST LOG -----------------------
GET  /v1/services  HTTP/1.1
HOST   : 172.16.16.4:443
HEADERS:
                   Accept: application/json
            Authorization: Basic ZGV2OmRldg== <-- HIDE THIS
             Content-Type: application/json
               User-Agent: go-resty v1.7 - https://github.com/go-resty/resty
BODY   :
***** NO CONTENT *****
----------------------------------------------------------

Any opinions? :)
Thanks
Ashley
@jeevatkm
Copy link
Member

@CallMeFoxie I agree, let's create an option in resty.

@jeevatkm jeevatkm added this to the v1.10.0 Milestone milestone Aug 28, 2018
@jeevatkm jeevatkm mentioned this issue Sep 6, 2018
Closed
jeevatkm added a commit that referenced this issue Sep 19, 2018
@jeevatkm
#180 #182 debug log callback added to customize log info before logging
fdc2f93
@jeevatkm
Copy link
Member

jeevatkm commented Sep 19, 2018 •
edited
Loading

@CallMeFoxie I have added the implementation on branch debug-log-enhancement fdc2f93, give it try and please let me know. I will merge it.

@jeevatkm jeevatkm mentioned this issue Sep 19, 2018
Merged
jeevatkm added a commit that referenced this issue Sep 20, 2018
@jeevatkm
#180 #182 debug log callback added to customize log info before loggi…
eae7644 
…ng (#186)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
v1.10.0 Milestone
Development

Successfully merging a pull request may close this issue.

#180 #182 debug log callback added to customize log info before logging go-resty/resty
2 participants
@jeevatkm @CallMeFoxie