Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method into struct Request to accept type url.Values for Query strings #213

Closed
jeevatkm opened this issue Jan 10, 2019 · 3 comments
Closed

Add method into struct Request to accept type url.Values for Query strings #213

jeevatkm opened this issue Jan 10, 2019 · 3 comments
Assignees
@jeevatkm
Labels
breaking change enhancement v2 For resty v2
Milestone
v2.0.0 Milestone

Comments

@jeevatkm
Copy link
Member

Refer to #166 (comment)
@jeevatkm jeevatkm added feature v2 For resty v2 labels Jan 10, 2019
@jeevatkm jeevatkm added this to the v2.0.0 Milestone milestone Jan 10, 2019
@jeevatkm jeevatkm self-assigned this Mar 7, 2019
@jeevatkm
Copy link
Member Author

jeevatkm commented Mar 7, 2019 •
edited
Loading

I have analyzed, it seems there are methods already exists in Resty to accept url.values for Query Parameters and Form Data.

So I will do following changes, for easy understanding:

  • Refactor method from SetMultiValueQueryParams to SetQueryParamsFromValues
  • Refactor method from SetMultiValueFormData to SetFormDataFromValues

jeevatkm added a commit that referenced this issue Mar 8, 2019
@jeevatkm
#213 refactored the method name for easy understanding
19e1822
@jeevatkm
Copy link
Member Author

jeevatkm commented Mar 8, 2019

It's done 😄

@jeevatkm jeevatkm closed this as completed Mar 8, 2019
@moorereason
Copy link
Contributor

This should be labeled as a breaking change.

@jeevatkm jeevatkm mentioned this issue Jun 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevatkm jeevatkm

Labels
breaking change enhancement v2 For resty v2
Milestone
v2.0.0 Milestone
Development

No branches or pull requests
2 participants
@moorereason @jeevatkm