Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetCookie per request #257

Closed
janekolszak opened this issue Jul 18, 2019 · 4 comments
Closed

SetCookie per request #257

janekolszak opened this issue Jul 18, 2019 · 4 comments
Assignees
@jeevatkm
Labels
enhancement v2 For resty v2
Milestone
v2.1.0 Milestone

Comments

@janekolszak
Copy link

Hi,
Shouldn't there be a SetCookie method for a Request?
@jeevatkm
Copy link
Member

@janekolszak yeah currently no easy to set cookie method at request each level. As you know it only exists at the client level.

I will add it, it's fairly straight forward to implement. If you're interested you can take a stab at it.

Stopgap suggestion:

Maybe you can try using the SetPreRequestHook until this enhancements come.

@jeevatkm jeevatkm added enhancement v2 For resty v2 labels Jul 20, 2019
@janekolszak
Copy link
Author

I'm just using SetHeader for now

@jeevatkm jeevatkm self-assigned this Sep 8, 2019
@jeevatkm jeevatkm added this to the v2.1.0 Milestone milestone Sep 8, 2019
jeevatkm added a commit that referenced this issue Sep 8, 2019
@jeevatkm
#257 added cookies methods for request instance
c4101e3
@jeevatkm
Copy link
Member

jeevatkm commented Sep 8, 2019

@janekolszak I have added cookie method for request instance in branch add-set-cookie-in-request. Can you try it out and let me know?

jeevatkm added a commit that referenced this issue Sep 12, 2019
@jeevatkm
#257 added cookies methods for request instance (#267)
30b66cd
@jeevatkm
Copy link
Member

It has been merged to master and scheduled for next release v2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevatkm jeevatkm

Labels
enhancement v2 For resty v2
Milestone
v2.1.0 Milestone
Development

No branches or pull requests
2 participants
@jeevatkm @janekolszak