Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context support #44

Closed
ei-grad opened this issue Nov 25, 2016 · 2 comments
Closed

Context support #44

ei-grad opened this issue Nov 25, 2016 · 2 comments
Assignees
@jeevatkm
Labels
enhancement
Milestone
v0.10 Milestone

Comments

@ei-grad
Copy link
Contributor

ei-grad commented Nov 25, 2016 •
edited
Loading

It would be nice to have a Request.SetContext method to set context for request cancellation like it is done in httpDo function described in https://blog.golang.org/context.
@ei-grad ei-grad mentioned this issue Nov 25, 2016
Merged
@ei-grad
Copy link
Contributor Author

ei-grad commented Nov 25, 2016

Oops, it would break golang <1.7, is it planned to keep support for them?

@jeevatkm
Copy link
Member

Support provide in PR #46. Merged to master.

@jeevatkm jeevatkm added this to the v0.10 Milestone milestone Dec 29, 2016
@jeevatkm jeevatkm self-assigned this Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevatkm jeevatkm

Labels
enhancement
Milestone
v0.10 Milestone
Development

No branches or pull requests
2 participants
@ei-grad @jeevatkm