Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Request.SetContext #46

Merged
merged 2 commits into from
Dec 29, 2016
Merged

Add Request.SetContext #46

merged 2 commits into from
Dec 29, 2016

Conversation

ei-grad
Copy link
Contributor

@ei-grad ei-grad commented Nov 25, 2016

Implements #44

@codecov-io
Copy link

codecov-io commented Nov 25, 2016

Current coverage is 96.53% (diff: 100%)

Merging #46 into master will increase coverage by 0.06%

@@             master        #46   diff @@
==========================================
  Files             6          8     +2   
  Lines           848        865    +17   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            818        835    +17   
  Misses           17         17          
  Partials         13         13          

Powered by Codecov. Last update 27219c0...8024c33

@jeevatkm
Copy link
Member

jeevatkm commented Dec 3, 2016

@ei-grad Thanks for your contribution.

Yes this feature only supported Go 1.7 and above. So we may have to limit this option. Let me have a look.

@jeevatkm jeevatkm self-assigned this Dec 3, 2016
@jeevatkm
Copy link
Member

@ei-grad I have quick question for this PR.

To achieve this PR to work properly, following needs to be done:

  • Please branch out fresh, since code quality improvements applied in master brach
  • We have to take advantage of Go build constraints reference
  • Create two files for type Request struct with definition for go1.7 & greater, go1.6 & below and implementation will be separate file which is common part
  • And test cases accordingly

This approach is compatible with all Go versions.

Would you like like to try and send PR?

@ei-grad
Copy link
Contributor Author

ei-grad commented Dec 29, 2016

Yep, I'll do that :).

@ei-grad ei-grad force-pushed the set-context branch 3 times, most recently from 6a02050 to e4161a2 Compare December 29, 2016 09:03
@ei-grad
Copy link
Contributor Author

ei-grad commented Dec 29, 2016

@jeevatkm done

@jeevatkm jeevatkm merged commit cca8945 into go-resty:master Dec 29, 2016
@jeevatkm jeevatkm mentioned this pull request Dec 29, 2016
@jeevatkm jeevatkm modified the milestone: v0.10 Milestone Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants