Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path param encoding is broken #781

Closed
sakateka opened this issue Mar 5, 2024 · 0 comments · Fixed by #782
Closed

Path param encoding is broken #781

sakateka opened this issue Mar 5, 2024 · 0 comments · Fixed by #782
Assignees
@sakateka
Labels
bug
Milestone
v2.12.0

Comments

@sakateka
Copy link
Contributor

sakateka commented Mar 5, 2024

Hi!
I have the following code example.

c.SetBaseURL("https://example.com/prefix")
r.SetPathParam("first", "1").
        SetPathParam("second", "2")
r.Get("{first}/{second}")

And after the release v2.10.0-rc.1 this example started failing.
The debug logs show the following

GET /prefix/%7Bfirst%7D/%7Bsecond%7D
HOST   :  example.com

I wrote the test and corrected the code, the PR is attached.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sakateka sakateka

Labels
bug
Milestone
v2.12.0
Development

Successfully merging a pull request may close this issue.

fix: encode path params with BaseURL and the first param at index zero (#781)
2 participants
@jeevatkm @sakateka