Fixes test failures in Windows #143
Conversation
Use filepath when constructing local file paths. Don't test Error() text since it's platform specific for DNS errors; rather, test for type net.DNSError.
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 9 9
Lines 1065 1065
=======================================
Hits 1023 1023
Misses 23 23
Partials 19 19Continue to review full report at Codecov.
|
|
*facepalm* I didn't use imperative mood in my git subject. How embarrassing. I can force-push a fix if you want me to. 🙄 |
There was a problem hiding this comment.
@moorereason Thank you for your PR. You're correct, I should have used filepath.Join to begin with.
request_test.go
Outdated
| @@ -1192,7 +1197,8 @@ func TestSRVInvalidService(t *testing.T) { | |||
| Get("/") | |||
|
|
|||
| assertNotNil(t, err) | |||
| assertEqual(t, true, strings.Contains(err.Error(), "no such host")) | |||
| assertType(t, net.DNSError{}, err) | |||
| fmt.Printf("%#v\n", err) | |||
There was a problem hiding this comment.
@moorereason Could you please remove this line?
|
@moorereason Feel free make one or more commits, I typically do I squash and merge. Also please let me the subject or comment line, I will use it during a merge. |
|
@moorereason Thanks again I have removed |
Use filepath when constructing local file paths. Don't test Error()
text since it's platform specific for DNS errors; rather, test for type
net.DNSError.