Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for overriding the header. #156

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Add support for overriding the header. #156

merged 1 commit into from
Jun 5, 2018

Conversation

sorribas
Copy link
Contributor

@sorribas sorribas commented Jun 5, 2018

This is a proposed fix for #155.

@codecov
Copy link

codecov bot commented Jun 5, 2018 •
edited
Loading

Codecov Report

Merging #156 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage    95.9%   95.91%   +<.01%     
==========================================
  Files           9        9              
  Lines        1074     1076       +2     
==========================================
+ Hits         1030     1032       +2     
  Misses         24       24              
  Partials       20       20
Impacted Files Coverage Δ
client.go 97.05% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc3ad73...3597b0e. Read the comment docs.

@jeevatkm jeevatkm self-requested a review June 5, 2018 23:12
@jeevatkm jeevatkm added this to the v1.7 Milestone milestone Jun 5, 2018
jeevatkm
jeevatkm approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorribas Thank you for the PR. I appreciate it.

@jeevatkm jeevatkm merged commit a9963f7 into go-resty:master Jun 5, 2018
@sorribas
Copy link
Contributor Author

sorribas commented Jun 6, 2018

@jeevatkm you're welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeevatkm jeevatkm jeevatkm approved these changes

Assignees

@sorribas sorribas

Labels
feature
Milestone
v1.7 Milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorribas @jeevatkm