Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for go-resty/resty#270 #271

Merged
merged 1 commit into from
Sep 10, 2019
Merged

fix for go-resty/resty#270 #271

merged 1 commit into from
Sep 10, 2019

Conversation

kmanley
Copy link

@kmanley kmanley commented Sep 10, 2019

No description provided.

@codecov
Copy link

codecov bot commented Sep 10, 2019 •
edited
Loading

Codecov Report

Merging #271 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   95.83%   95.84%   +0.01%     
==========================================
  Files           9        9              
  Lines        1128     1131       +3     
==========================================
+ Hits         1081     1084       +3     
  Misses         25       25              
  Partials       22       22
Impacted Files Coverage Δ
util.go 92.95% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd15327...edc056f. Read the comment docs.

@jeevatkm jeevatkm self-requested a review September 10, 2019 22:06
jeevatkm
jeevatkm approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmanley Thank you for the PR and fixing an issue 👍

@jeevatkm jeevatkm merged commit a95a117 into go-resty:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeevatkm jeevatkm jeevatkm approved these changes

Assignees

@kmanley kmanley

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmanley @jeevatkm