Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing first request and successfully retrying carries error from first #290

Merged
merged 3 commits into from
Dec 1, 2019
Merged

Failing first request and successfully retrying carries error from first #290

merged 3 commits into from
Dec 1, 2019

Conversation

phillc
Copy link
Contributor

@phillc phillc commented Nov 22, 2019

Proves #289

phillc
phillc commented Nov 22, 2019
View reviewed changes
retry_test.go Outdated
assertEqual(t, http.StatusOK, resp.StatusCode())
assertEqual(t, "hello", authSuccess.Message)

assertNil(t, responseErr)
Copy link
Contributor Author

@phillc phillc Nov 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This last assertion is the one that fails

@codecov
Copy link

codecov bot commented Nov 22, 2019 •
edited
Loading

Codecov Report

Merging #290 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   95.48%   95.49%   +<.01%     
==========================================
  Files           9        9              
  Lines        1152     1153       +1     
==========================================
+ Hits         1100     1101       +1     
  Misses         29       29              
  Partials       23       23
Impacted Files Coverage Δ
middleware.go 91.15% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e29360f...6572463. Read the comment docs.

jeevatkm
jeevatkm approved these changes Dec 1, 2019
View reviewed changes
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phillc Thank you for the PR.

@jeevatkm jeevatkm merged commit d7b9766 into go-resty:master Dec 1, 2019
@jeevatkm jeevatkm added this to the v2.2.0 Milestone milestone Jan 15, 2020
@jeevatkm jeevatkm added bug v2 For resty v2 labels Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeevatkm jeevatkm jeevatkm approved these changes

Assignees

@phillc phillc

Labels
bug v2 For resty v2
Milestone
v2.2.0 Milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phillc @jeevatkm