Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support http.RoundTripper #91

Merged
merged 4 commits into from
Aug 18, 2017
Merged

Added support http.RoundTripper #91

merged 4 commits into from
Aug 18, 2017

Conversation

jeevatkm
Copy link
Member

Supersede #74 and solves #65

@codecov
Copy link

codecov bot commented Aug 17, 2017

Codecov Report

Merging #91 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   96.72%   96.79%   +0.06%     
==========================================
  Files           9        9              
  Lines         947      966      +19     
==========================================
+ Hits          916      935      +19     
  Misses         16       16              
  Partials       15       15
Impacted Files Coverage Δ
client.go 95.78% <100%> (+0.27%) ⬆️
default.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d07bf...cc88910. Read the comment docs.

This was referenced Aug 17, 2017
@jeevatkm jeevatkm merged commit 8d8edd7 into master Aug 18, 2017
@bak1an
Copy link
Contributor

bak1an commented Aug 18, 2017

Great work pushing this into master @jeevatkm! Thanks!

Sorry for being absent, have been quite busy with moving to another country lately.

🍻

@jeevatkm
Copy link
Member Author

Thank you @bak1an 🍻

No worries, I hope your move went well, take care.

@jeevatkm jeevatkm deleted the bak1an-roundtripper branch August 19, 2017 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants