Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unpack params with asasalint #649

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Fix unpack params with asasalint #649

merged 2 commits into from
Jul 8, 2022

Conversation

alingse
Copy link
Contributor

@alingse alingse commented Jul 7, 2022

see #642 before

rod/must.go:870:24: pass []any as any to func Eval func(js string, args ...interface{}) *github.com/go-rod/rod.EvalOptions

run local test success

$go test -coverprofile=coverage.out -run TestElementMustWait
parallel test 4
PASS
coverage: 13.2% of statements
ok      github.com/go-rod/rod   5.918s

@alingse
Copy link
Contributor Author

alingse commented Jul 7, 2022

@ysmood

@alingse alingse mentioned this pull request Jul 7, 2022
Closed
@ysmood ysmood merged commit b754960 into go-rod:master Jul 8, 2022
@ysmood
Copy link
Member

ysmood commented Jul 8, 2022

Better to add asasalint to golangci-lint, this tool is very useful 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysmood ysmood ysmood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alingse @ysmood