updateIcon: Respect system colour scheme #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the extension toolbar icon does not respect the selected colour scheme (light/dark mode). This causes the light-mode icon to be used on a dark mode toolbar, thus making the icon almost unreadable. This change implements a simple check that picks the correct icon based on the system's colour scheme instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the extension toolbar icon does not respect the selected colour scheme (light/dark mode). This causes the light-mode icon to be used on a dark-mode toolbar, making it almost unreadable.
The underlying cause is the static reference to the icons within the
background-script.js, which always points to the light-mode version of the icons.This change implements a simple check that instead picks the icon set based on the system's reported dark/light mode and defaults to light mode if no determination can be made.