-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build/Install instructions cleanup #268
Comments
Thanks for helping out.
I think updating the wiki is fine for now. Changes can always be rolled back. I'll probably move most of the wiki contents to the docs/ folder at some point.
Please don't add instructions for installing Go. Perhaps add a link to Go's own docs? I'd prefer to keep the docs (and especially the questions people ask) Shiori-specific.
Go modules make |
I'm still getting the error when I'm building using
|
@constraintAutomaton what version of go is the build failing with? I've seen a number of build failures (on the SBCs I use) when the go version was below version I just checked and https://github.com/go-shiori/shiori/wiki/Installation still mentions 1.12 so I'm about to go update that :) |
I'm using |
Thanks for raising this, it's on my mind as well. I've opened #336 to discuss moving documentation directly into the repository. |
I'd like to propose moving install instructions into the readme (from the wiki https://github.com/go-shiori/shiori/wiki/Installation). Any concerns with that? I can update the wiki instead but that won't go through a review (PR) process. This applies to both manual and Docker build
#264 shows an alternative technique.
From my notes https://github.com/clach04/shiori
Shiori can be built but not using the original wiki instructions to use
go get ...
, with go1.13.11 under Raspbian GNU/Linux 9 (stretch) get:Original wiki documents minimum version of Go 1.12. So unclear why
go get ...
fails, the alternative is to build from source (manually or with Docker).See Dockerfile for deployment with Docker, image uses Alpine (which requires Alpine Go to build, Debian builds of Shiori do not work in Alpine, will see
not found
errors).To build issue:
Quick setup of Go:
Then in .profile (etc.)
Later versions should work, #243 (comment) indicates go1.14.1 works
The text was updated successfully, but these errors were encountered: