Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Docker build #264

Merged
merged 1 commit into from
Aug 20, 2020
Merged

bug: Docker build #264

merged 1 commit into from
Aug 20, 2020

Conversation

lapwat
Copy link
Contributor

@lapwat lapwat commented Aug 11, 2020

Dockerfile is now using local source instead of downloading the sources from github.

Build is now working.

This was referenced Aug 11, 2020
Closed
Closed
@symgryph
Copy link

I ran this it builds fine. Tests worked.

symgryph
symgryph approved these changes Aug 11, 2020
View reviewed changes
Copy link

@symgryph symgryph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes worked and fixed the broken build.

@clach04 clach04 mentioned this pull request Aug 16, 2020
Closed
@deanishe
Copy link
Contributor

Thanks very much.

@deanishe deanishe merged commit a950bfe into go-shiori:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symgryph symgryph symgryph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lapwat @symgryph @deanishe @scality-q