Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove golang from final docker image #341

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Remove golang from final docker image #341

merged 1 commit into from
Feb 7, 2022

Conversation

n8225
Copy link
Contributor

@n8225 n8225 commented Feb 6, 2022

The current Dockerfile uses the golang:alpine image for the final image, which makes the final image much larger than needed. This changes the final image to alpine and uses images from ghcr.io(It looks like these are ghcr.io official images pulled from dockerhub). Also added a label to the image that will link the package to the repository.

@n8225 n8225 changed the title Remove golang from final image Remove golang from final docker image Feb 6, 2022
@fmartingr fmartingr merged commit cf88489 into go-shiori:master Feb 7, 2022
@fmartingr
Copy link
Member

Thank you @n8225 ! I've already merged and pushed the new image to the GHCR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants