-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup CI/CD workflows #365
Conversation
Holy molly @n8225 this sounds awesome! I can't thank you enough for all the work you've done, it's very well put and easy to use for us maintaners. Amazing. It seems that the linter is giving quite a few errors already in your examples (in master), I will fix those after this is merged so we can have green PRs for any old/new contribution. Again, thanks a lot. |
I still need to implement deleting old docker images, but other than that this PR is ready to go. |
Thanks a lot for your contribution @n8225, this will save a lot of time in reviews and releases. The cleanup can be done in a later step as well since .5GB of space can hold a few releases. |
Awesome work @n8225! I'm going to merge it and I will try the workflows once I merge some bugfixes. Thanks! |
Example results:
https://github.com/n8225/shiori/actions
https://github.com/n8225/shiori/releases/tag/v1.5.2
https://github.com/n8225/shiori/pkgs/container/shiori
Note: The buildx workflow does not use the Dockerfile in the repo. It creates a Dockerfile that reuses the binary created by goreleaser. The docker image created is also ran as a non-root user, so could be a breaking change(I beleive you can just fun it with -u root to continue running as root).
Invalidates #278
Related Issues: #263 #260
Closes #254 #267 #238 #273 #278