Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Upgrade aws s3 v2 #369

Merged
merged 1 commit into from
Jun 10, 2024
Merged

✨ Upgrade aws s3 v2 #369

merged 1 commit into from
Jun 10, 2024

Conversation

tosone
Copy link
Contributor

@tosone tosone commented Jun 9, 2024

No description provided.

@tosone tosone added the enhancement New feature or request label Jun 9, 2024
@tosone tosone self-assigned this Jun 9, 2024
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 25.03%. Comparing base (41b49e9) to head (31f1a3b).

Files Patch % Lines
pkg/storage/s3/s3.go 78.12% 14 Missing ⚠️
pkg/configs/middleware.go 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
- Coverage   25.63%   25.03%   -0.61%     
==========================================
  Files         271      269       -2     
  Lines       19180    18817     -363     
==========================================
- Hits         4917     4710     -207     
+ Misses      13790    13665     -125     
+ Partials      473      442      -31     
Flag Coverage Δ
unit-test-mysql 25.01% <81.25%> (-0.57%) ⬇️
unit-test-postgresql 25.03% <81.25%> (-0.56%) ⬇️
unit-test-sqlite3 25.03% <81.25%> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tosone tosone force-pushed the tosone-1 branch 8 times, most recently from ec4c38a to 9ed1f9a Compare June 10, 2024 12:25
@tosone tosone enabled auto-merge June 10, 2024 13:06
@tosone tosone added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit 95816e7 Jun 10, 2024
14 checks passed
@tosone tosone deleted the tosone-1 branch June 10, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant