add applicationPassword & some rest-api compatiable with wordpress rest-api #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
有几处Linter 错误 :) |
1379
reviewed
Nov 25, 2023
| } | ||
|
|
||
| func verifyHeader(header string) bool { | ||
| compile, err := regexp.Compile("^Basic [a-z\\d/+]*={0,2}") |
There was a problem hiding this comment.
这里可以把regexp对象定义成一个全局变量，不需要每次Compile，性能更好
|
其实我觉得这个功能更适合用插件去实现，不过目前确实还不支持插件:( |
也没必要一定要用插件实现，wordpress已经将类似功能从插件移植到自身了 |
|
本质上这个接口是对wp的适配，所以我认为不应该放到sonic中。 |
其实这个应该拆成两部分，一部分是sonic自身的rest-api，这部分可以放到sonic自身，提高整体的可玩性。第二部分是针对wp接口的兼容，这个放插件更合适一点，我还是保留我的意见。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post
Tag
Category
User