ui: Fix inspector CSS. Fix custom map control #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the viewer was migrated from mapboxgl to maplibregl the associated CSS references were not updated. This caused the styling for the inspector to use default browser styles. The style references have now been corrected. Additionally the debug tile line map control implementation was was using mapboxgl CSS classes so the control was not being added to the map. This has been fix.
iwpnd
approved these changes
Dec 29, 2024
Pull Request Test Coverage Report for Build a2a0d5115Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the viewer was migrated from mapboxgl to maplibregl the associated CSS references were not updated. This caused the styling for the inspector to use default browser styles. The style references have now been corrected.
Additionally the debug tile line map control implementation was was using mapboxgl CSS classes so the control was not being added to the map. This has been fix.