Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow forcing path style for s3 compatible API requests. #745

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Allow forcing path style for s3 compatible API requests. #745

merged 1 commit into from
Mar 4, 2021

Conversation

johngian
Copy link
Contributor

@johngian johngian commented Mar 2, 2021

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 60f65f327-PR-745

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 45.628%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cache/s3/s3.go 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
server/viewer.go 3 61.54%
Totals Coverage Status
Change from base Build 7f0e7e660: 0.004%
Covered Lines: 5390
Relevant Lines: 11813
💛 - Coveralls

gdey
gdey approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johngian
Copy link
Contributor Author

johngian commented Mar 3, 2021

I think that this patch fixes #719

@ARolek
Copy link
Member

ARolek commented Mar 3, 2021

@johngian excellent. Thanks for pointing out that issue.

@ARolek ARolek merged commit 8e40caf into go-spatial:v0.13.x Mar 4, 2021
@ARolek ARolek mentioned this pull request Mar 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdey gdey gdey approved these changes

@ARolek ARolek Awaiting requested review from ARolek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johngian @coveralls @ARolek @gdey