Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ui version checking during build #946

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

ARolek
Copy link
Member

@ARolek ARolek commented Aug 29, 2023

The compiled UI code naming convention changed at some point and the previous way to parse the version from the file name no longer aligned with the new convention.

closes #942

@ARolek ARolek requested a review from gdey as a code owner August 29, 2023 22:51
@ARolek
Copy link
Member Author

ARolek commented Aug 29, 2023

@zaa76 can you try this branch to see if you're getting the proper output when calling tegola version?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 852c66085

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.906%

Totals Coverage Status
Change from base Build 096b5d903: 0.0%
Covered Lines: 6556
Relevant Lines: 13977

💛 - Coveralls

Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The compiled UI code naming convention changed at some point
and the previous way to parse the version from the file name
no longer aligned with the new convention.

closes #942
@ARolek ARolek merged commit 2012f76 into master Sep 1, 2023
8 checks passed
@ARolek ARolek deleted the issue-942-view-not-built branch September 1, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build version from source v0.17.0
3 participants