Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go vet error #1173

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Fix go vet error #1173

merged 1 commit into from
Nov 27, 2020

Conversation

methane
Copy link
Member

@methane methane commented Nov 27, 2020 •
edited
Loading

Description

Fix https://travis-ci.com/github/go-sql-driver/mysql/jobs/448595379#L663

$ go vet ./...
# github.com/go-sql-driver/mysql
./benchmark_test.go:130:6: call to (*B).Fatal from a non-test goroutine
The command "go vet ./..." exited with 2.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

shogo82148
shogo82148 approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@methane methane merged commit f6dcc3d into go-sql-driver:master Nov 27, 2020
@methane methane deleted the fix-vet branch November 27, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo82148 shogo82148 shogo82148 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methane @shogo82148