-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update changelog for releasing v1.8.1 #1576
Conversation
WalkthroughThis update introduces several significant enhancements and bug fixes to improve compatibility, performance, and usability. Key highlights include addressing race condition issues, dropping support for older Go versions, and implementing new options for better configuration and compatibility with MySQL. The changes aim to enhance the overall reliability and efficiency of the application, making it more robust and user-friendly. Changes
Related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@coderabbitai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional comments: 2
CHANGELOG.md (2)
- 7-42: The major changes listed for version 1.8.0 include several enhancements and new features, such as using
SET NAMES charset COLLATE collation
, path escaping of dbname in DSN, dropping support for older Go versions, and introducing new options using the Functional Option Pattern. Verify that these changes have been implemented as described and that the documentation accurately reflects the functionality and implications of these changes.Verification successful
The major changes listed for version 1.8.0, including the use of
SET NAMES charset COLLATE collation
, path escaping of dbname in DSN, dropping support for older Go versions, and the introduction of new options using the Functional Option Pattern, are accurately documented in the CHANGELOG.md as verified by the shell script output. The documentation reflects the functionality and implications of these changes as described.* 30-42: The "Other changes" section for version 1.8.0 lists various enhancements and fixes. It's important to ensure that each listed change is accurately described and that the links to pull requests or issues are correct and lead to the relevant discussions or implementations.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the implementation of major changes for version 1.8.0. # Check for commits or pull requests implementing the mentioned features. rg --type md 'SET NAMES charset COLLATE collation' CHANGELOG.md rg --type md 'PathEscape dbname in DSN' CHANGELOG.md rg --type md 'Drop Go 1.13-17 support' CHANGELOG.md rg --type md 'Functional Option Pattern' CHANGELOG.mdLength of output: 853
Verification successful
To continue verifying the accuracy and relevance of the links in the "Other changes" section, the next step involves checking the remaining pull requests. Here's the script to fetch and analyze the titles and descriptions of the next set of pull requests:
The verification process has confirmed that all links in the "Other changes" section of the CHANGELOG.md for version 1.8.0 are accurate and lead to the relevant discussions or implementations as described. Each listed change is accurately described, and the links to pull requests are correct.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the accuracy and relevance of the links in the "Other changes" section. curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1422 | jq '.title, .body' curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1408 | jq '.title, .body' curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1428 | jq '.title, .body' # Continue for each link in the section.Length of output: 2180
Script:
#!/bin/bash # Continue verifying the accuracy and relevance of the links in the "Other changes" section. curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1389 | jq '.title, .body' curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1424 | jq '.title, .body' curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1309 | jq '.title, .body' curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1499 | jq '.title, .body' curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1506 | jq '.title, .body' curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1470 | jq '.title, .body' curl -s https://api.github.com/repos/go-sql-driver/mysql/pulls/1518 | jq '.title, .body'Length of output: 9017
Thanks for reviewing |
### Description go-sql-driver#1559 and go-sql-driver#1567 are fixed. Let's release a new version v1.8.1. ### Checklist - [x] Code compiles correctly - [x] Created tests which fail without the change (if possible) - [x] All tests passing - [x] Extended the README / documentation, if necessary - [x] Added myself / the copyright holder to the AUTHORS file <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Addressed race condition issues for enhanced stability. - **New Features** - Improved database compatibility with charset and collation adjustments. - Enhanced security and flexibility through the introduction of new configuration options. - **Major Changes** - Dropped support for older versions of Go (1.13-1.17) to leverage newer language features. - Improved number parsing for efficiency and accuracy. - Added configurable logging per connection for better diagnostics. - **Enhancements** - Fixed issues with ColumnType.DatabaseTypeName to improve data handling. - Introduced connection attributes for more detailed connection information. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
cherry pick of shogo82148@476df92 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Addressed race conditions when the context is canceled. - **New Features** - Enhanced database connection with charset and collation settings. - Improved path escaping in database names. - Dropped support for Go versions 1.13-17. - Implemented parsing numbers over text protocol. - Introduced new configuration options for advanced usage. - **Enhancements** - Made logger configurable per connection. - Fixed handling of `mediumint unsigned` in `ColumnType.DatabaseTypeName`. - Added connection attributes for more detailed connection information. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…iver#1577) cherry pick of shogo82148@476df92 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Addressed race conditions when the context is canceled. - **New Features** - Enhanced database connection with charset and collation settings. - Improved path escaping in database names. - Dropped support for Go versions 1.13-17. - Implemented parsing numbers over text protocol. - Introduced new configuration options for advanced usage. - **Enhancements** - Made logger configurable per connection. - Fixed handling of `mediumint unsigned` in `ColumnType.DatabaseTypeName`. - Added connection attributes for more detailed connection information. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description
#1559 and #1567 are fixed.
Let's release a new version v1.8.1.
Checklist
Summary by CodeRabbit
Bug Fixes
New Features
Major Changes
Enhancements