DSN: check for separating slash #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utils.go
Outdated
Member
There was a problem hiding this comment.
I'd prefer errInvalidDSNNoSlash - the other errors indicate what's wrong, but the slash is not invalid (or one more than needed), it is missing.
Member
|
@julienschmidt can you please address my comment so we can mess around with utils.go and utils_test.go in other PRs? If you don't want to change the name I'm fine, too. LGTM either way 😀 |
julienschmidt
added a commit
that referenced
this pull request
Dec 6, 2013
DSN: check for separating slash
Member
|
👍 |
Member
|
too late, but this should also be mentioned in CHANGELOG.md ... as well as the old password handling when it's finally fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #186