Add support for connection attributes. #343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -228,7 +233,22 @@ func (mc *mysqlConn) writeAuthPacket(cipher []byte) error { | |||
| // User Password | |||
| scrambleBuff := scramblePassword(cipher, []byte(mc.cfg.passwd)) | |||
|
|
|||
| attrs := make(map[string]string) | |||
| attrs["_os"] = runtime.GOOS | |||
| attrs["_client_name"] = "Go MySQL Driver" | |||
|
Just noting on the importance of the feature (regardless of the code review itself), as connection attributes turn to be standard in the C library; and can contain such information that is otherwise unachievable via MySQL elsewise (e.g. provide true hostname while connecting behind proxy; e.g. process ID of course). |
dveeden
added a commit
to dveeden/go-mysql-driver
that referenced
this pull request
Jun 8, 2015
dveeden
added a commit
to dveeden/go-mysql-driver
that referenced
this pull request
Jun 9, 2015
This sets attribute _client_name with the value "Go MySQL Driver" Also sets _os, _platform, _pid and program_name by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets attribute _client_name with the value "Go MySQL Driver"
Also sets _os, _platform, _pid and program_name by default.
This supersedes #333