Skip to content

Conversation

@julienschmidt
Copy link
Member

Description

The strict mode may not be confused with the server-side strict mode
set via the sql_mode system variable.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Fixes #376

The strict mode may not be confused with the server-side strict mode
set via the sql_mode system variable.
Fixes #376
@julienschmidt julienschmidt added this to the v1.3 milestone Oct 26, 2016
@arnehormann
Copy link
Member

LGTM - but I wouldn't merge before #489 lands. Both yours 😉

@julienschmidt
Copy link
Member Author

Please use GitHub's new PR Review tool and mark it as approved.

screen shot 2016-10-26 at 15 56 09

Copy link
Member

@arnehormann arnehormann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienschmidt julienschmidt merged commit 68ea39f into master Oct 26, 2016
@julienschmidt julienschmidt deleted the strict branch October 26, 2016 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants