Skip to content

Conversation

erwamartin
Copy link
Contributor

Description

This package can't be built anymore with Google App Engine:

github.com/go-sql-driver/mysql/appengine.go:20:67: undefined: addr
github.com/go-sql-driver/mysql/appengine.go:20:74: undefined: net

Looks like the issue is related with this change: 89ec2a9 (#941)

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shogo82148 shogo82148 merged commit 8f4b98d into go-sql-driver:master Apr 4, 2019
@julienschmidt julienschmidt added this to the v1.5.0 milestone Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants