Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support linux #1

Merged
merged 1 commit into from
Jul 21, 2019
Merged

Support linux #1

merged 1 commit into from
Jul 21, 2019

Conversation

dawidd6
Copy link
Contributor

@dawidd6 dawidd6 commented Jul 20, 2019

Homebrew since 2.0.0 release officially supports linux too.

This PR makes possible installing task via brew on linux.

@andreynering
Copy link
Member

Hi @dawidd6,

Thanks for opening this pull request!

Do you now if it'd be possible to support both i386 and amd64 builds for Linux?

As a second note, after this is merged we need to update this section to mention Linux support on Homebrew.

@dawidd6
Copy link
Contributor Author

dawidd6 commented Jul 21, 2019

Homebrew officially supports only x86_64 architecture, but I think it can be done by checking output of method OS.bits.

@andreynering
Copy link
Member

Well, on our side it'd be easy to support i386, since it's only another URL and checksum on the formula.

But since it's not official, I think we can support amd64 for now, and if someone needs i386 support, they can open another issue/PR about it.

Thanks! 😉

@andreynering andreynering merged commit abe7643 into go-task:master Jul 21, 2019
andreynering added a commit to go-task/task that referenced this pull request Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants