refactor following review

cmd/task/task.go

@@ -58,7 +58,7 @@ func run() error {
  entrypoint := flags.Entrypoint
 
  if flags.Version {
- fmt.Printf("Task version: %s\n", ver.GetVersion(true))
+ fmt.Printf("Task version: %s\n", ver.GetVersionWithSum())
  return nil
  }
 

internal/compiler/compiler.go

@@ -203,6 +203,6 @@ func (c *Compiler) getSpecialVars(t *ast.Task) (map[string]string, error) {
  "TASKFILE": t.Location.Taskfile,
  "TASKFILE_DIR": filepath.Dir(t.Location.Taskfile),
  "USER_WORKING_DIR": c.UserWorkingDir,
- "TASK_VERSION": version.GetVersion(false),
+ "TASK_VERSION": version.GetVersion(),
  }, nil
 }

internal/version/version.go

@@ -5,21 +5,25 @@ import (
  "runtime/debug"
 )
 
-var version = ""
-
-func GetVersion(withSum bool) string {
- if version != "" {
- return version
- }
+var (
+ version = ""
+ sum = ""
+)
 
+func init() {
  info, ok := debug.ReadBuildInfo()
  if !ok || info.Main.Version == "" {
- return "unknown"
+ version = "unknown"
+ } else {
+ version = info.Main.Version
+ sum = info.Main.Sum
  }
+}
 
- ver := info.Main.Version
- if info.Main.Sum != "" && withSum {
- ver += fmt.Sprintf(" (%s)", info.Main.Sum)
- }
- return ver
+func GetVersion() string {
+ return version
+}
+
+func GetVersionWithSum() string {
+ return fmt.Sprintf("%s (%s)", version, sum)
 }

setup.go

@@ -238,7 +238,7 @@ func (e *Executor) doVersionChecks() error {
 
  // Get the current version of Task
  // If we can't parse the version (e.g. when its "devel"), then ignore the current version checks
- currentVersion, err := semver.NewVersion(version.GetVersion(false))
+ currentVersion, err := semver.NewVersion(version.GetVersion())
  if err != nil {
  return nil
  }