Version set via ldflags is ignored when building from source tarball

[stefanb]

• Task version: 3.38.0
• Operating system: All
• Experiments enabled: likely irrelevant

In

• go-task 3.38.0 Homebrew/homebrew-core#176003

It was noted, that the --version test failed with Expected /Task\ version:\ 3\.38\.0/ to match "Task version: (devel) ()\n

Meaning that the test was expecting Task version: 3.38.0 but task --version returned Task version: (devel) ()\n

Even if the correct version was passed to the compiler in ldflags.

Bug introduced with

• fix: version check #1663

Where it was assumed that the version would be empty by default:

task/internal/version/version.go

Lines 13 to 21 in 88b0950

	func init() {
	info, ok := debug.ReadBuildInfo()
	if !ok || info.Main.Version == "" {
	version = "unknown"
	} else {
	version = info.Main.Version
	sum = info.Main.Sum
	}
	}

Where in fact Version defaults "(devel)" if Go compiler cannot read git info during build, which is the case when building from the downloaded source tarball.
You can try that in playground, where there is also no git info present: https://go.dev/play/p/MCLXd4QaUru

Because of this the version set via Go ldflags is always overrwritten and never used/returned by GetVersion*() functions.

This is the reason for

• Task version v3.38.0 is not available in Homebrew #1707