-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: version check #1663
fix: version check #1663
Conversation
529efb9
to
03df707
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. Bit of an oversight on my part when doing #1465. A couple of minor suggestions
It's done @pd93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Fixes #872
Following this PR :
task/setup.go
Lines 241 to 253 in a74b0bc
This does not work when the sum is displayed in the version
Cf :
And
task/internal/version/version.go
Lines 21 to 23 in a74b0bc